Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System configuration parameter 'return_accno' used but not declared/documented #1229

Closed
ehuelsmann opened this issue Jan 8, 2016 · 3 comments
Assignees
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. needs-cleanup
Milestone

Comments

@ehuelsmann
Copy link
Member

https://github.com/ledgersmb/LedgerSMB/blob/master/LedgerSMB/IS.pm#L892 references the configuration parameter $LedgerSMB::Sysconfig::return_accno. This parameter isn't defined in the configuration file "ledgersmb.conf", nor is it documented in Sysconfig.pm.

This parameter should probably be moved from 'ledgersmb.conf' to the database, because this is 100% company related configuration: it's the account used to post the (negative) income on which is caused by parts returns.

@ehuelsmann ehuelsmann added this to the 1.5 milestone Jan 8, 2016
@ehuelsmann ehuelsmann added the bite-sized Deemed a good starting point for new contributors to learn about the code base. label May 19, 2016
@einhverfr einhverfr modified the milestones: 1.5, 1.5-rc2 Jul 27, 2016
@einhverfr
Copy link
Member

einhverfr commented Aug 7, 2016

IIRC the one user of this feature eventually moved to other systems. Right now you can do product returns in a way that requires some manual adjustment later. I would really like to see a good product return system implemented at some point but that is probably down the line a bit.

@einhverfr
Copy link
Member

Actually on further review, any use fo this code should be removed. I am ok bumping that to 1.6

@einhverfr einhverfr modified the milestones: 1.6, 1.5-rc2 Aug 10, 2016
@einhverfr einhverfr self-assigned this Aug 10, 2016
@einhverfr
Copy link
Member

in my remove-chart branch, I remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bite-sized Deemed a good starting point for new contributors to learn about the code base. needs-cleanup
Projects
None yet
Development

No branches or pull requests

2 participants