Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken upgrade test migrating 1.3 -> 1.4 (GIFI check) #1443

Closed
sbts opened this issue Apr 18, 2016 · 0 comments
Closed

broken upgrade test migrating 1.3 -> 1.4 (GIFI check) #1443

sbts opened this issue Apr 18, 2016 · 0 comments
Assignees
@sbts
Labels
type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Milestone
1.4.28

Comments

@sbts
Copy link
Member

sbts commented Apr 18, 2016 •
edited by ehuelsmann

While upgrading a user database, the GIFI existence check fires on NULL values, preventing upgrades on a database in valid (GIFI) state.
@sbts sbts self-assigned this Apr 18, 2016
@sbts sbts added the type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0) label Apr 18, 2016
@sbts sbts added this to the 1.4.28 milestone Apr 18, 2016
sbts added a commit to sbts/LedgerSMB that referenced this issue Apr 18, 2016
@sbts
Fix for issue ledgersmb#1443 broken upgrade test in 1.3-1.4.sql
5933333
sbts added a commit to sbts/LedgerSMB that referenced this issue Apr 18, 2016
@sbts
Fix for issue ledgersmb#1443 broken upgrade test in 1.3-1.4.sql
6509dd7
ehuelsmann added a commit that referenced this issue Apr 18, 2016
@ehuelsmann
Merge pull request #1445 from sbts/master-issue-1443-broken-upgrade-t…
d526542 
…est-13-14

Fix for issue #1443 broken upgrade test in 1.3-1.4.sql
ehuelsmann added a commit that referenced this issue Apr 18, 2016
@ehuelsmann
Merge pull request #1444 from sbts/1.4-issue-1443-broken-upgrade-test…
650ea0b 
…-13-14

Fix for issue #1443 broken upgrade test in 1.3-1.4.sql
@ehuelsmann ehuelsmann changed the title broken upgrade test in 1.3-1.4.sql broken upgrade test migrating 1.3 -> 1.4 (GIFI check) Apr 18, 2016
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Apr 18, 2016
@ehuelsmann
* Don't block upgrades on valid GIFI state (accounts without GIFI), f…
704333c 
…ixes ledgersmb#1443.

Conflicts:
	LedgerSMB/Upgrade_Tests.pm
@ehuelsmann ehuelsmann mentioned this issue Apr 18, 2016
Merged
ehuelsmann added a commit that referenced this issue Apr 19, 2016
@ehuelsmann
Merge pull request #1451 from ehuelsmann/1.4-issue-1443
080a00d 
* Don't block upgrades on valid GIFI state (accounts without GIFI), fixes #1443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbts sbts

Labels
type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Projects
None yet
Milestone
1.4.28
Development

No branches or pull requests
1 participant
@sbts