Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNL and B/S reports are not correctly indented for Full hierarchy #5990

Closed
aungzwin10 opened this issue Sep 16, 2021 · 2 comments
Closed

PNL and B/S reports are not correctly indented for Full hierarchy #5990

aungzwin10 opened this issue Sep 16, 2021 · 2 comments

Comments

@aungzwin10
Copy link
Member

Current indentation as below
Screen Shot 2021-09-16 at 12 11 06 PM

It should indent like below, no?
Screen Shot 2021-09-16 at 12 14 56 PM

@ehuelsmann
Copy link
Member

Yes, it should. I'm thinking that the thing missing, is probably the CSS required to do the indentation.

@aungzwin10
Copy link
Member Author

No, the CSS for indentation is available, but i think the behavior is not same as you expected. I can inspect in the browser DevTools for the below CSS.

#PNL th[colspan="1"].indent {
width: 1em;
}
#PNL th[colspan="2"].indent {
width: 2em;
}
#PNL th[colspan="3"].indent {
width: 3em;
}
#PNL th[colspan="4"].indent {
width: 4em;
}
#PNL th[colspan="5"].indent {
width: 5em;
}
#PNL th[colspan="6"].indent {
width: 6em;
}
#PNL th[colspan="7"].indent {
width: 7em;
}
#PNL th[colspan="8"].indent {
width: 8em;
}
#PNL th[colspan="9"].indent {
width: 9em;
}

ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Oct 25, 2021
… reports

Apparently, using a single cell with "just" a colspan and a width, doesn't
work as expected. Instead, generate a series of cells, each with the
unit of indentation that's expected. This has the additional benefit that
the CSS only needs to list a single indentation level, because there's
going to be a series of repeated 1-level indentations.
ehuelsmann added a commit that referenced this issue Oct 26, 2021
Fix #5990: Incorrect indentation in hierarchical PNL and B/S reports
ehuelsmann added a commit that referenced this issue Oct 26, 2021
Fix #5990: Incorrect indentation in hierarchical PNL and B/S reports
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Nov 8, 2021
To prove it works, run the tests in the non-standard schema named 'xyz';
the standard schema being "public".

Closes ledgersmb#5990.
ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants