Qty discounts, #1899
Merged
Qty discounts, #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,6 +124,11 @@ sub price_matrix { | |||
| - ($sellprice * ($mref->{pricebreak} / 100)); | |||
| } | |||
| $ref->{sellprice} = $sellprice; | |||
| if ($mref->{qty} > $form->{qtycache}->{$ref->{id}}){ | |||
There was a problem hiding this comment.
@einhverfr just ran into a problem with the quantity cache, I think: when loading an existing invoice from the database, the price matrix is applied to each item individually instead of running the pricematrix at the end.
(which explains part of the cases of 'rowcount' being '' or undefined...
There was a problem hiding this comment.
It seems that this: https://github.com/ledgersmb/LedgerSMB/blob/master/lib/LedgerSMB/IS.pm#L1600
loop needs to be split in a loop loading from the database and a loop applying the prices from the price matrix.
I'm assuming there's something similar going on in the 'ir' and 'oe' sides of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1790