1.5 Fix #2800 can't delete unused account after books closed #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing books creates zero entries in the account_checkpoint table for accounts which have never been used. We allow deletion of such accounts, so the associated zero-value account_checkpoint records must be deleted before the account to avoid foreign-key errors.
ehuelsmann
reviewed
May 14, 2017
sql/changes/LOADORDER
Outdated
| @@ -44,4 +44,5 @@ | |||
| 1.5/issue-2380-modify-tax_extended_entry_id-constraint.sql | |||
| 1.5/issue-2278-modify-acc_trans-index.sql | |||
| 1.5/template_menu3.sql | |||
| 1.5/issue-2800-cant-delete-unused-account-after-books-closed.sql | |||
There was a problem hiding this comment.
No need to create an sql/changes/ item for this one: modules are always reloaded.
sql/changes/ only comes in when changing the schema definition (adding/removing indexes, adding/changing/removing columns and tables, etc).
…ount" This reverts commit 436217b. In response to feedback - no need to create sql/changes entries for module update as modules are always reloaded.
Closing books creates zero entries in the account_checkpoint table for accounts which have never been used. We allow deletion of such accounts, so the associated zero-value account_checkpoint records must be deleted before the account to avoid foreign-key errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that associated zero-value records in account_checkpoint are deleted before the account, to avoid foreign-key errors.