1.5 Backport minimal LedgerSMB::File fix and tests #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported tests from master.
1.5 did not de-reference file content, when extracting files from the database for use in invoice templates. It was therefore writing a perl PGObject::Type::ByteString reference to the file, rather than the actual binary content. This is a mimimal one-line bugfix, rather than the more extensive changes applied to 1.6 and master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LedgerSMB::File did not de-reference file content, when extracting files
from the database for use in invoice templates. It was therefore
writing a perl PGObject::Type::ByteString reference to the file,
rather than the actual binary content.
This is a mimimal one-line bugfix to LedgerSMB::File, rather than the
more extensive changes applied to 1.6 and master.
Additionally the new tests have been backported - without the
dependency on LedgerSMB::Magic.