Fix #4781: Cannot save batch in Payments due to date format #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
changed the title
The existing code passes all values from the request straight into the inner layers of the application, forfeiting its role as decoupling point between the web and the inner operation of the application. This commit separates the concerns of 'handling of web input' from 'marshalling payments into the database' into their respective modules. This also means that the workflow script filters out the contacts and invoices which have been indicated /not/ to be part of the payment(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code passes all values from the request straight into the
inner layers of the application, forfeiting its role as decoupling point
between the web and the inner operation of the application.
This commit separates the concerns of 'handling of web input' from
'marshalling payments into the database' into their respective
modules. This also means that the workflow script filters out the
contacts and invoices which have been indicated /not/ to be part of
the payment(s).