1.7 overpayment reversal #4816
Merged
1.7 overpayment reversal #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Post date not set, therefore violating integrity constraints on INSERT
* SQL function overpayment__reverse()
* not ported to the MC paradigm (uses amount instead of amount_bc/amount_tc)
* calls payment__reverse in incorrect way
* doesn't truely reverse as it takes currency and
exchangerate args (no longer)
Note that GL transactions are part of (over)payments/-receipts, in which case they need to be posted just as any other case. They can't be part of AR/AP vouchers/batches. If they were, though, I guess they should be posted too.
…code
Note that old code wants '{ base => ... }', which differs from newer code and
that all DBObject code is old code...
ehuelsmann
force-pushed
the
1.7-overpayment-reversal
branch
from
45a9cdc
to
f3e7a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.