Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure to document roles #7380

Merged
merged 12 commits into from May 28, 2023

Conversation

ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Apr 30, 2023

Closes #3305
Closes #7376

@ehuelsmann
Copy link
Member Author

@neilt I think this is one of the items you're missing for the book: the ability to extract role documentation from our application. Here's at least a start.

@ehuelsmann ehuelsmann force-pushed the feature/role-documentation branch 2 times, most recently from b0d7f4f to 2c15e90 Compare May 1, 2023 07:04
@neilt
Copy link
Contributor

neilt commented May 1, 2023

Excellent, I was going about this the other way around. Getting the definitions in the book first, then moving them to the role comments. But I think this is the best way.

Copy link
Contributor

@neilt neilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, well very good. I'll get started on a perl file to retrieve these descriptions from the database for the book.

sql/modules/Roles.sql Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
@neilt
Copy link
Contributor

neilt commented May 1, 2023

I have the perl script written to gather the role comments from the database, so I hope this can be merged soon so I can test the script.

Copy link
Member Author

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved requests from @neilt.

sql/modules/Roles.sql Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
sql/modules/Roles.sql Outdated Show resolved Hide resolved
@ehuelsmann ehuelsmann force-pushed the feature/role-documentation branch 3 times, most recently from c6d9d33 to e53762e Compare May 15, 2023 20:41
@ehuelsmann ehuelsmann enabled auto-merge (squash) May 28, 2023 10:12
@ehuelsmann ehuelsmann merged commit 6370e15 into ledgersmb:master May 28, 2023
12 checks passed
@ehuelsmann ehuelsmann deleted the feature/role-documentation branch May 28, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It seems that one of role ap_transaction_all or ap_all_transactions is wrong Doc base user
3 participants