Migrate sl30 mc currencies #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
reviewed
May 21, 2023
There was a problem hiding this comment.
I'm surprised: our schema had an "fx_transaction" indicator. I'm pretty sure that came from SQL Ledger. "mc" removed that indicator by moving from the fx values into the "amount_tc" column. By doing so, many rows would be dropped.
What happened to the rows with the "fx_transaction" == TRUE?
ylavoie
force-pushed
the
migrate-sl30-mc-currencies1
branch
2 times, most recently
from
9cafde4
to
bed49ba
Compare
ylavoie
force-pushed
the
migrate-sl30-mc-currencies1
branch
from
bed49ba
to
e90067e
Compare
ylavoie
force-pushed
the
migrate-sl30-mc-currencies1
branch
from
e90067e
to
ac5295d
Compare
ehuelsmann
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SL3.0 migration with transactions using multiple currencies.