Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADR describing the decisions for our REST API #7427

Merged
merged 2 commits into from May 30, 2023
Merged

Add ADR describing the decisions for our REST API #7427

merged 2 commits into from May 30, 2023

Conversation

ehuelsmann
Copy link
Member

No description provided.

freelock
freelock reviewed May 27, 2023
View reviewed changes
Copy link
Member

@freelock freelock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok for a start, although a bit long in stretches, and I think we should also include GraphQL as we were considering that early on...

@freelock freelock requested a review from ylavoie May 27, 2023 21:19
@ehuelsmann
Copy link
Member Author

@freelock, thanks for this rewrite! No comments; as far as I'm concerned, this can be integrated.

ylavoie
ylavoie approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ylavoie ylavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@ehuelsmann ehuelsmann merged commit ab5c170 into ledgersmb:master May 30, 2023
12 checks passed
@ehuelsmann ehuelsmann deleted the cleanup/rest-api-adr branch May 30, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freelock freelock freelock left review comments

@ylavoie ylavoie ylavoie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehuelsmann @freelock @ylavoie