Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert buttons on journal screen to workflow #7516

Merged
merged 4 commits into from Jul 17, 2023

Conversation

ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Jul 16, 2023

Relates to #7457; demystifies when to show which buttons.

Missing migration of existing transactions.

Thoughts on migrating existing transactions:

  • Don't migrate:
    • Year-end transactions [table: yearend]
    • Fixed assets transactions [table: asset_report]
    • Payment transactions [table: payment]
    • Inventory adjustment reports [table: inventory_report]
  • What how to correctly initialize GL transactions that are part of a batch of some kind?

@ehuelsmann ehuelsmann requested a review from ylavoie July 16, 2023 21:35
@ehuelsmann ehuelsmann force-pushed the cleanup/gl-workflow branch 2 times, most recently from c6a3517 to 85583a7 Compare July 17, 2023 07:39
@ehuelsmann ehuelsmann marked this pull request as ready for review July 17, 2023 20:38
@ehuelsmann ehuelsmann enabled auto-merge (squash) July 17, 2023 20:39
@ehuelsmann ehuelsmann merged commit 171a4f9 into ledgersmb:master Jul 17, 2023
12 checks passed
@ehuelsmann ehuelsmann deleted the cleanup/gl-workflow branch July 17, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant