Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make right-to-left locale always assigned #7548

Merged
merged 1 commit into from Jul 27, 2023
Merged

Make right-to-left locale always assigned #7548

merged 1 commit into from Jul 27, 2023

Conversation

ylavoie
Copy link
Contributor

@ylavoie ylavoie commented Jul 27, 2023

Left-to-right and right-to-left indicators must always follow the assigned locale

@ylavoie ylavoie requested a review from ehuelsmann July 27, 2023 06:07
ehuelsmann
ehuelsmann requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the change looks good, but I think the trigger to update the UI is timed incorrectly, screwing up the tests.

@ehuelsmann ehuelsmann self-requested a review July 27, 2023 18:39
@ehuelsmann ehuelsmann merged commit 2f6e9fd into ledgersmb:master Jul 27, 2023
19 checks passed
@ylavoie ylavoie deleted the fix/rtl-locales branch November 7, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuelsmann ehuelsmann ehuelsmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ylavoie @ehuelsmann