This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
[wip] E35 #957
Open
[wip] E35 #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state/aggregator_v3.go
Outdated
| predicates.Add(1) | ||
| g.Go(func() (err error) { | ||
| mf.storage, mf.storageIdx, mf.storageHist, err = a.storage.mergeFiles(ctx, files.storage, files.storageIdx, files.storageHist, r.storage, workers) | ||
| predicates.Done() |
There was a problem hiding this comment.
always call wg.Done in defer to avoid deadlocks on panic
state/domain.go
Outdated
| @@ -33,6 +33,7 @@ import ( | |||
|
|
|||
| "github.com/RoaringBitmap/roaring/roaring64" | |||
| btree2 "github.com/tidwall/btree" | |||
| atomic2 "go.uber.org/atomic" | |||
There was a problem hiding this comment.
we dropped support of go1.18 in last release. now can use sync/atomic.Int32
state/domain_mem.go
Outdated
| } | ||
|
|
||
| func (l *KVList) Reset() { | ||
| //l.Keys = l.Keys[:0] |
There was a problem hiding this comment.
I prefer as the first step: get much green tests. And ten introduce prealloc/reset optimizations.
state/domain_mem.go
Outdated
| *Domain | ||
|
|
||
| etl *etl.Collector | ||
| mu sync.RWMutex |
There was a problem hiding this comment.
do we need shared mutex between domains?
state/domain_mem.go
Outdated
| //} | ||
| return func(k []byte, value []byte, _ etl.CurrentTableReader, next etl.LoadNextFunc) error { | ||
| // if its ordered we could put to history each key excluding last one | ||
| tx := binary.BigEndian.Uint64(k[len(k)-8:]) |
There was a problem hiding this comment.
tx variable name is reserved for Database Transaction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.