Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

[wip] E35 #957

Open
wants to merge 872 commits into
base: main
Choose a base branch
from
Open

[wip] E35 #957

wants to merge 872 commits into from

Conversation

awskii
Copy link
Collaborator

@awskii awskii commented Mar 27, 2023

No description provided.

predicates.Add(1)
g.Go(func() (err error) {
mf.storage, mf.storageIdx, mf.storageHist, err = a.storage.mergeFiles(ctx, files.storage, files.storageIdx, files.storageHist, r.storage, workers)
predicates.Done()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always call wg.Done in defer to avoid deadlocks on panic

state/domain.go Outdated
@@ -33,6 +33,7 @@ import (

"github.com/RoaringBitmap/roaring/roaring64"
btree2 "github.com/tidwall/btree"
atomic2 "go.uber.org/atomic"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dropped support of go1.18 in last release. now can use sync/atomic.Int32

}

func (l *KVList) Reset() {
//l.Keys = l.Keys[:0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer as the first step: get much green tests. And ten introduce prealloc/reset optimizations.

*Domain

etl *etl.Collector
mu sync.RWMutex
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need shared mutex between domains?

//}
return func(k []byte, value []byte, _ etl.CurrentTableReader, next etl.LoadNextFunc) error {
// if its ordered we could put to history each key excluding last one
tx := binary.BigEndian.Uint64(k[len(k)-8:])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tx variable name is reserved for Database Transaction

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants