refactor trie package a bit #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trie/rlphacks/bytes.go
Outdated
| @@ -37,7 +39,7 @@ func (b RlpEncodedBytes) DoubleRLPLen() int { | |||
|
|
|||
| func encodeBytesAsRlpToWriter(source []byte, w io.Writer, prefixGenFunc func([]byte, int, int) int, prefixBufferSize uint) error { | |||
| // > 1 byte, write a prefix or prefixes first | |||
| if len(source) > 1 || (len(source) == 1 && source[0] >= 0x80) { | |||
| if len(source) > 1 || (len(source) == 1 && source[0] >= rlp.EmptyStringCode) { | |||
There was a problem hiding this comment.
Strictly speaking, in this particular case, 0x80 is not used as the encoding of the empty string. It is another constant of the RLP algorithm, which happens to be the same value as the encoding of the empty string.
There was a problem hiding this comment.
It is related though, otherwise how would they know if that is a prefix or not, so I understand why it is there :) But I can add a comment about that too.
BlinkyStitt
pushed a commit
to llamanodes/erigon
that referenced
this pull request
Sep 1, 2023
battlmonstr
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Delete code with account, add code test * Fix test Co-authored-by: Alexey Sharp <alexeysharp@Alexeys-iMac.local>
anshalshukla
pushed a commit
that referenced
this pull request
Mar 5, 2024
* save l1Blockhash separately * add l1blockhash and ger to block info treeon injected batches * fixed a bug on delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129