Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing scrollBy TypeScript definition #931

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Add missing scrollBy TypeScript definition #931

merged 2 commits into from
Jun 26, 2019

Conversation

danielholmes
Copy link
Contributor

As outlined in the README

Is it a bugfix ?

Is it a new feature ?

  • No

Describe what you've done:

Added a TypeScript definition for scrollBy to index.d.ts

How to test it ?

import Swiper from 'react-native-swiper'

const swiper: Swiper = new Swiper({})
if (swiper) {
  swiper.scrollBy(1, false)
}

This will now pass the TypeScript compiler whereas before it wouldn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants