changed str << to str +=

[MadBomber]

rake test before change results in about 5 errors.

rake test after change had no errors.

[leejarvis]

What version of Ruby are you using, @MadBomber? We have specs that run against all of these versions and they're currently all passing, so if there's a version the tests are failing on I'd want to add that to the matrix.

[leejarvis]

Ah I've just read the issue. You must be running with frozen string literals. I'm up for fixing this but I'm still interested in how/why you received this error message. Do you have # frozen_string_literal: true at the top of your Ruby files or something else?

[MadBomber]

I set the system environment variable RUBYOPT to be:

export RUBYOPT=-W0 --enable-frozen-string-literal

So I could start catching problems that could account for some weird side-effects that I was seeing in some production code. Then my common CLI utilities stopped working.

I use your gem in my cli_helper gem which I use to build all of my cli utilities. I tracked it back to the use of << instead of += for string concat.

[olleolleolle]

I have one change request: the chmod of the file changed to 755, perhaps that can be changed back?

[leejarvis]

I think we should fix this but we should also enable frozen strings in Slop using the # frozen_string_literal: true pragma

[MadBomber]

I have one change request: the chmod of the file changed to 755, perhaps that can be changed back?

yes.

[leejarvis]

Merged, thanks! -- not enabling frozen_string_literal just yet but this is now on master