Bugfix whitespace newlines #1
Conversation
```html <span>blah</span> <span>blah</span> ``` should render with a space as ``` blah blah ```
|
Thanks - looks like this is failing some tests on the CI, can you take a look? Also, i think this would be better implemented as an option rather than the default, despite what the W3C says, for backwards compat reasons. |
|
Actually lets make this the default, so just go ahead and fix the test failures (would be also better to squash these commits down so we don't have a commit that breaks the tests). Ta! |
|
Thanks die the quick reaction. I will look into it later this afternoon.
|
replace use of $self in the reggrp_data closures that was causing the following memory cycle (amongst others): Cycle #1 HTML::Packer A->{_reggrp_global} => Regexp::RegGrp B Regexp::RegGrp B->{_reggrp} => @C @c->[2] => Regexp::RegGrp::Data D Regexp::RegGrp::Data D->{_store} => &E closure &E, $self => $F $F => HTML::Packer A now we are using package variables set when minify is called thus handle any change to the state and remove the cycles
Enters have meaning as white space in html (https://www.w3.org/TR/html5/infrastructure.html#space-character). So removing a newline without regard for context can result in altering the html.
E.g.
should render with a space as