Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix whitespace newlines, Squashed #2

Merged
merged 1 commit into from Jan 13, 2016
Merged

Bugfix whitespace newlines, Squashed #2

merged 1 commit into from Jan 13, 2016

Conversation

basbloemsaat
Copy link
Contributor

Squashed version of #1

Enters have meaning as white space in html (https://www.w3.org/TR/html5/infrastructure.html#space-character). So removing a newline without regard for context can result in altering the html.

E.g.

<span>blah</span>
<span>blah</span>

should render with a space as

blah blah

commit 9390932
Author: Bas Bloemsaat <bas@bloemsaat.com>
Date:   Wed Jan 13 16:06:56 2016 +0100

    whitespace in html still the same, even if js is untouched

commit 6f74b4e
Author: Bas Bloemsaat <bas@bloemsaat.com>
Date:   Wed Jan 13 14:12:53 2016 +0100

    tests

commit 5eda603
Author: Bas Bloemsaat <bas@bloemsaat.com>
Date:   Wed Jan 13 13:55:04 2016 +0100

    Fix replacing newlines between tags

    ```html
    <span>blah</span>
    <span>blah</span>
    ```

    should render with a space as
    ```
    blah blah
    ```
@basbloemsaat basbloemsaat changed the title Squashed commit of the following: Bugfix whitespace newlines, Squashed Jan 13, 2016
leejo pushed a commit that referenced this pull request Jan 13, 2016
@leejo leejo merged commit 75662b6 into leejo:master Jan 13, 2016
@leejo
Copy link
Owner

leejo commented Jan 13, 2016

Thanks! v2.01 on its way to CPAN,

@basbloemsaat
Copy link
Contributor Author

Thanks for your very fast reaction. Exemplary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants