Update global parameters in a CustomBondForce
#263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
CustomBondForce
is commonly used to implement scaled14 interactions excluded from aCustomNonbondedForce
and can contain different global parameters, for example, the scale parameter to scale the interactions by. This PR also checks the custom bond force for global parameters when copying forces to a new openmm system. See this issue openforcefield/smirnoff-plugins#36