Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not call to lowercase on your custom authentication keys #7

Open
ekryski opened this issue Mar 25, 2015 · 1 comment
Open

Should not call to lowercase on your custom authentication keys #7

ekryski opened this issue Mar 25, 2015 · 1 comment

Comments

@ekryski
Copy link

ekryski commented Mar 25, 2015

First off. Thanks for writing the module! Much appreciated.

I'm going to issue a PR to remove the call of toLowerCase() on these lines. This actually bit me and I spent quite a bit of time trying to figure out what went wrong. I don't think it should be the responsibility of passport-token to make the strings lowercase. I think that concern should be left up to the person implementing.

ekryski added a commit to ekryski/passport-token that referenced this issue Mar 25, 2015
@leepowelldev
Copy link
Owner

Hi. Sorry, this module was written really very quickly for a personal project (that never even made it to production). After that I kind of forgot about it - and never really thought anyone would use it!

I'll try to do a review in the next couple of days and get your changes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants