Only one declaration is allowed

[yleydier]

Tinyxml2 allows only one declaration. It prevents the reading files containing and .

Reference : http://www.xml-model.info/

Commenting out the test around line 970 of tinyxml2.cpp fixes the bug, but the correct way to do this would be to test if all previous nodes are declarations instead of testing if declaration nodes are the first node of the document.

[Dmitry-Me]

Good! Fixing this would also resolve #340 I can craft a fix next week. @leethomason, do you have any objections?

[ajtruckle]

Not sure I am following this right. I am no XML but I am using my XML file with a XSL file, thus this is my declaration:

Andrew

Date: Fri, 4 Dec 2015 06:42:16 -0800
From: notifications@github.com
To: tinyxml2@noreply.github.com
Subject: Re: [tinyxml2] Only one declaration is allowed (#399)

Good! Fixing this will also resolve #340 I can craft a fix next week. @leethomason do you have any objections?

—
Reply to this email directly or view it on GitHub.

[leethomason]

#340 is a partial fix from a previous bug.

Since TinyXML-2 doesn't actually interpret the declarations, I don't think the limit (only one) is really helping. I've been leaning to the other: remove the limitation entirely and just read all the declarations it finds.

[snowkoan]

The current code also prevents comments at the start of an XML file. It appears that this is technically not valid XML but it's a fairly common pattern, at least in our code base.

For example, this will fail to parse:

<!-- Package file for product X -->
<?xml version="1.0" encoding="UTF-8"?>
<package>
</package>

[leethomason]

Good point - flagging as bug. I agree that's something that shouldn't cause a parse failure.

[Dmitry-Me]

@leethomason This should have been resolved once #496 was merged