Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Refactor targets export variable and improve comments #789

Merged
merged 4 commits into from Sep 17, 2020
Merged

cmake: Refactor targets export variable and improve comments #789

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e86e947
cmake: Use CMAKE_PROJECT_NAME instead of PROJECT_NAME
offlinemark Dec 3, 2019
57cd52b
cmake: Use TARGETS_EXPORT_NAME var throughout file
offlinemark Dec 3, 2019
588c657
cmake: Clarify comment around exported cmake script
offlinemark Dec 3, 2019
60e9616
cmake: Move TARGETS_EXPORT_NAME to top
offlinemark Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Expand Up @@ -48,6 +48,8 @@ set(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
# to distinguish between debug and release lib
set(CMAKE_DEBUG_POSTFIX "d")

set(TARGETS_EXPORT_NAME "${CMAKE_PROJECT_NAME}Targets")

add_library(tinyxml2 tinyxml2.cpp tinyxml2.h)

set_target_properties(tinyxml2 PROPERTIES
Expand All @@ -73,12 +75,13 @@ else()
endif(MSVC)
endif()

# export targets for find_package config mode
# Export cmake script that can be used by downstream project
# via `include()`
export(TARGETS tinyxml2
FILE ${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}Targets.cmake)
FILE ${CMAKE_BINARY_DIR}/${TARGETS_EXPORT_NAME}.cmake)

install(TARGETS tinyxml2
EXPORT ${CMAKE_PROJECT_NAME}Targets
EXPORT ${TARGETS_EXPORT_NAME}
RUNTIME
DESTINATION ${CMAKE_INSTALL_BINDIR}
COMPONENT tinyxml2_runtime
Expand Down Expand Up @@ -121,7 +124,6 @@ if(NOT TARGET uninstall)
endif()

include(CMakePackageConfigHelpers)
set(TARGETS_EXPORT_NAME "${PROJECT_NAME}Targets")
configure_package_config_file(
"Config.cmake.in"
"${CMAKE_BINARY_DIR}/${CMAKE_PROJECT_NAME}Config.cmake"
Expand All @@ -138,6 +140,7 @@ install(FILES
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${CMAKE_PROJECT_NAME}
COMPONENT tinyxml2_config)

install(EXPORT ${CMAKE_PROJECT_NAME}Targets NAMESPACE tinyxml2::
# Export targets for find_package config mode
install(EXPORT ${TARGETS_EXPORT_NAME} NAMESPACE tinyxml2::
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${CMAKE_PROJECT_NAME}
COMPONENT tinyxml2_config)