Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track no 8 and 9 show up as 0 for flac files #10

Closed
bahamas10 opened this issue Oct 1, 2012 · 1 comment
Closed

track no 8 and 9 show up as 0 for flac files #10

bahamas10 opened this issue Oct 1, 2012 · 1 comment

Comments

@bahamas10
Copy link

certain flac tracks of mine report track no 0, if their track numbers are 8 or 9.

I suspect there is some octal conversion happening... but i haven't dug through the source yet.

In the output below, tracks 8 and 9 report a trackno of 0. this CD was ripped using soundjuicer on Ubuntu 12.04.. this has happened for other songs as well.

dave @ [ lifeforce :: (Linux) ] ~/dev/node-musicnamer $ ./bin/musicnamer.js --tags ../../Desktop/As\ I\ Lay\ Dying/Awakened/*

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 10 - My Only Home.flac -----

{ title: 'My Only Home',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 10, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 11 - Tear Out My Eyes.flac -----

{ title: 'Tear Out My Eyes',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012',
  track: { no: 11, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 1 - Cauterize.flac -----

{ title: 'Cauterize',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012',
  track: { no: 1, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 2 - A Greater Foundation.flac -----

{ title: 'A Greater Foundation',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 2, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 3 - Resilience.flac -----

{ title: 'Resilience',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 3, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 4 - Wasted Words.flac -----

{ title: 'Wasted Words',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012',
  track: { no: 4, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 5 - Whispering Silence.flac -----

{ title: 'Whispering Silence',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 5, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 6 - Overcome.flac -----

{ title: 'Overcome',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 6, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 7 - No Lungs to Breathe.flac -----

{ title: 'No Lungs to Breathe',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 7, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 9 - Washed Away.flac -----

{ title: 'Washed Away',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012-09-25',
  track: { no: 0, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }

----- processing ../../Desktop/As I Lay Dying/Awakened/Disc 1 - 8 - Defender.flac -----

{ title: 'Defender',
  artist: [ 'As I Lay Dying' ],
  albumartist: [ 'As I Lay Dying' ],
  album: 'Awakened',
  year: '2012',
  track: { no: 0, of: 11 },
  genre: [],
  disk: { no: 1, of: 0 },
  picture: 
   [ { format: 'jpg',
       data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 01 01 2c 01 2c 00 00 ff e1 00 fa 45 78 69 66 00 00 4d 4d 00 2a 00 00 00 08 00 06 01 1a 00 05 00 00 00 01 00 00 00 ...> } ] }
@bahamas10
Copy link
Author

code in #11

leetreveil added a commit that referenced this issue Oct 1, 2012
@leetreveil
Merge pull request #11 from bahamas10/fix-octal-parse
b90e82f 
Fixes #10 : 08, 09, etc being parsed as octal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leetreveil @bahamas10