Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Images in favor of slimmer dependencies #18

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

timholy
Copy link
Collaborator

@timholy timholy commented Aug 4, 2022

On my machine, this reduces the time for using OCReract from
3.6s to 1.1s.

Also, at this point ImageIO is considerably better at PNG IO than ImageMagick,
so I took the opportunity to update that dependency as well.

On my machine, this reduces the time for `using OCReract` from
3.6s to 1.1s.
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #18 (44ad77a) into master (d795665) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           1        1           
  Lines          50       50           
=======================================
  Hits           48       48           
  Misses          2        2           
Impacted Files Coverage Δ
src/tesseract.jl 96.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@leferrad leferrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job! In my case it also reduced the import time. Thanks for that @timholy !!

@leferrad leferrad merged commit 147b368 into leferrad:master Aug 4, 2022
@timholy timholy deleted the teh/slim_deps branch August 5, 2022 05:20
@leferrad leferrad mentioned this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants