Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nodeletize #287

Merged
merged 4 commits into from Jan 19, 2021
Merged

Feature/nodeletize #287

merged 4 commits into from Jan 19, 2021

Conversation

timonh
Copy link

@timonh timonh commented Dec 23, 2020

  • This pull request adds the option to use nodelet to run darknet_ros instead of node.
  • Adds a reference launch file for use of nodelet.
  • Node version remains available and unaltered.

tomlankhorst
tomlankhorst reviewed Dec 24, 2020
View reviewed changes
darknet_ros/src/yolo_object_detector_nodelet.cpp Outdated
/*
* yolo_object_detector_nodelet.cpp
*
* Created on: Dec 19, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed if you would like to.

tomlankhorst
tomlankhorst approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@tomlankhorst tomlankhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenwel
Copy link
Member

lorenwel commented Jan 4, 2021

LGTM

mbjelonic
mbjelonic reviewed Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@mbjelonic mbjelonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this after fixing my minor comments.

darknet_ros/CMakeLists.txt Outdated
@@ -58,6 +58,8 @@ find_package(catkin REQUIRED
actionlib
darknet_ros_msgs
image_transport
nodelet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary line.

darknet_ros/CMakeLists.txt Outdated
@@ -77,6 +79,8 @@ catkin_package(
std_msgs
darknet_ros_msgs
image_transport
nodelet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

darknet_ros/src/yolo_object_detector_nodelet.cpp Outdated
@@ -0,0 +1,29 @@
/*
* Author: Marko Bjelonic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add your name here since it is your contribution. :)

@mbjelonic mbjelonic merged commit dd119bc into master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbjelonic mbjelonic mbjelonic left review comments

@tomlankhorst tomlankhorst tomlankhorst approved these changes

@lorenwel lorenwel lorenwel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timonh @lorenwel @tomlankhorst @mbjelonic