Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDP controller does not generate a stable rollout. #10

Closed
mustang66ytz opened this issue Aug 9, 2021 · 4 comments
Closed

DDP controller does not generate a stable rollout. #10

mustang66ytz opened this issue Aug 9, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mustang66ytz
Copy link

Describe the bug
what(): DDP controller does not generate a stable rollout.

To Reproduce
Steps to reproduce the behavior:
I basically modified the mobile manipulator example by changing the UR robotics arm to a Kinova robotics arm, and I have ignored the constraints from the self collision

Expected behavior
The mobile manipulator with kinova arm should converge its end-effector to the interactive marker.

Screenshots
If applicable, add screenshots to help explain your problem.
ocs2_ddp_unstable_rollout

ocs2_mobile_kinova.mp4

I would like to understand from the algorithmic aspect why this error occurs, thanks for any suggestions or guidance!

@tomlankhorst tomlankhorst added the bug Something isn't working label Aug 22, 2021
@farbod-farshidian
Copy link
Contributor

farbod-farshidian commented Oct 13, 2021

We have extended the mobile manipulator example to many different commercially available robotic arms. This feature is under review and will be merged soon. I will post on this issue once the feature is incorporated.

@dHonerkamp
Copy link

Hi, I'm facing a similar issue trying to integrate the PR2 robot. Do you maybe have an update on the integration of these arms @farbod-farshidian ? It would be very useful to see some more examples.

A second question I am facing is how to incorporate joint limits for a new robot? I could not find any example of this for the existing robots. While the mobile manipulator docs mentions it, it only implements joint velocity limits. Do I add this with an additional StateConstraint?

@farbod-farshidian
Copy link
Contributor

A second question I am facing is how to incorporate joint limits for a new robot? I could not find any example of this for the existing robots. While the mobile manipulator docs mentions it, it only implements joint velocity limits. Do I add this with an additional StateConstraint?

It would be best if you do this through a StateConstraint. You can then add this as a soft constraint with DoubleSidedPenalty.

@Mayankm96
Copy link
Member

We have now updated the mobile manipulator example with joint position constraints as well as more robotic examples. These include the Franka Panda arm, the Kinova Jaco2, PR2, and Clearpath Ridgeback with the UR5 arm on it. Please check the documentation on how to run these:

https://leggedrobotics.github.io/ocs2/robotic_examples.html#mobile-manipulator

As a heads up, since we don't have these robotic platforms, we have not tested them outside of the dummy simulation node. We happily welcome contributions to it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants