Mod compat

[Qendolin]

• Updated version to 2.1.0
• Implement [Suggestion] Compatibility with ValleyCraft & BetterNether/End chains #13
  • Added built-in compatibility for Valley Craft, BetterNether and Better End
  • Knot type can be changed by starting a link
• Fix Chain links do not transfer correctly when used within a structure block #15
• Fix Breaking a chain that's linked to a player does not drop #14
• Fix Chain Knots don't get destroyed form explosions #16
• Fixed animation problems when placing chains
• Fixed not being able to place held chains when not holding a chain item
• Fixed issues with place / break sounds
• Fixed knot model when placed on wall
• Fixed not being able to summon chain links with commands
• Fixed crit / knockback sounds being played when attacking a chain
• Fixed item dropping when breaking a chain in creative mode in some cases
• Added future-proof nbt fixer
• Reduced packet size
• Improved chain lighting
• Improved logging
• Improved formatting
• Improved if nesting
• Tweaked the chain collision box height

[Qendolin]

Test World.zip

[Qendolin]

I still need to do one last test, which is creating a dummy mod and adding ConnectibleChains compatibility to it

[Qendolin]

It works! Ready for review.

java/net/fabricmc/example/ExampleMod.java

if(FabricLoader.getInstance().isModLoaded("connectiblechains")) {
  ChainTypesRegistry.register(Items.DIRT);
}

resources/assets/minecraft/models/entity/chain/dirt.json

{
  "textures": {
    "chain": "minecraft:textures/block/dirt",
    "knot": "minecraft:textures/block/dirt"
  }
}

[Qendolin]

There might be an issue with resource priority where f.e. valley craft cannot override the default copper_chain model because it has a lesser priority. I haven't encountered this issue in my testing but I don't see why it cannot happen. I'll have to do some changes to how builtin types are loaded.

[Arathain]

Using structure blocks to move chains has weird side effects - seemingly only chains which share the same X axis are stored properly. Screenshots attached below.

[Arathain]

removing this line of code seems to fix things

[Qendolin]

That is very interesting, since I already had that exact same issue and fixed it. But now it's back.
Removing that line only works when no mirror is applied.

[Qendolin]

I've tested all possible combinations of mirroring and rotation, this should work now.

[legoatoom]

Amazing work. Just a small tweaks in regards for error handling.

• Do not throw errors, log them.
• No longer use lo4j as there are now other ones that fabric wants you to use. (look in discord I do not know the exact name right know)

Finally, I am seeing a lot of classes that do not have an explanation for their existence as javadoc. It is just very important to me that I can read your code later.

[Qendolin]

"No longer use log4j as there are now other ones that fabric wants you to use.". Do you mean slf4j? I'm not sure if that is available before 1.18.2

[legoatoom]

Nice

[legoatoom]

"No longer use log4j as there are now other ones that fabric wants you to use.". Do you mean slf4j? I'm not sure if that is available before 1.18.2

Does this mean that the current code does not work in 1.18.2?
Or can I publish this new version?