Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #80

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Update CONTRIBUTING.md #80

merged 1 commit into from
Mar 10, 2021

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Mar 9, 2021

Add note regarding testing on MacOS.

@KapJI
Update CONTRIBUTING.md
359d843 
Add note regarding testing on MacOS.
@KapJI KapJI added the documentation Improvements or additions to documentation label Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
✅ google_home is added to https://github.com/home-assistant/brands NICE!
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Tuesday)
✅ README.md exists
✅ Requirements validation
✅ Python wheels
✅ HACS load check

leikoilja
leikoilja approved these changes Mar 10, 2021
View reviewed changes
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seem that problem on my setup, but i guess that must be useful for others. Are you on amd64?

@leikoilja leikoilja merged commit b843ad2 into master Mar 10, 2021
@leikoilja leikoilja deleted the how-to-build-grpc-on-mac branch March 10, 2021 05:51
@KapJI
Copy link
Collaborator Author

KapJI commented Mar 10, 2021

Yes, I'm on amd64. May depend on installed XCode version as well, I have 12.4.0.
There is a discussion in grpc/grpc#25060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leikoilja leikoilja leikoilja approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KapJI @leikoilja