Refactor CS move functions to chunkserver entry #210
+874
−795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkserverEntry was using a C-like linked list like this: - PacketStruct *outputHead = nullptr; - PacketStruct **outputTail = &outputHead; This change replaces it with a std::list: - std::list<std::unique_ptr<PacketStruct>> outputPackets; The commit also uses smart pointers for the list elements and for the members readPacket and writePacket. Some of the related functions were moved (and renamed) to the ChunkserverEntry struct, where they look more natural.
This commit is focused on replacing the old 'uint8_t *packet' by 'std::vector<uint8_t> packet' in PacketStruct. The change looks simple at first glance but aims for: - Simplified memory management (malloc and free was used before). - Reuse of already allocated memory. - Use of move semantics. - Simplified destruction and cleanup. - Shorter code. - Remove void* and casts.
- Rename variable 'i' to bytesRead or bytesWritten according context. - Replace NULL by nullptr. - Remove magic number.
Better usage of emplace_back in NetworkWorkerThread to avoid temporary empty object creation.
The destructor handles this automatically.
Even if the probability is very low, calling front in an empty list could trigger undefined behavior.
This commit moves most of the hanging functions in network_worker_thread.cc to the ChunkserverEntry class. Where they make more sense due to their responsibilities. Also: - The code now is shorter and easier to read. - There is no need to pass a pointer to the ChunkserverEntry every time for almost all functions. - Lines are also shorter. - Every function was documented. - Small code style aplied close to the related lines. - Better function names. This is a partial refactor, the next step is to separate the ChunkserverEntry into its own files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MUST be merged after PR#206]
This commit moves most of the hanging functions in
network_worker_thread.cc to the ChunkserverEntry class. Where they make
more sense due to their responsibilities. Also:
for almost all functions.
This is a partial refactor, the next step is to separate the
ChunkserverEntry into its own files.