Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing in Zoom subdomains breaking regex #260

Merged
merged 1 commit into from
May 3, 2021

Conversation

JamesMcMahon
Copy link
Contributor

@JamesMcMahon JamesMcMahon commented May 3, 2021

Status

READY

Description

My company has a cased subdomain whose meeting location were not being picked up by Meeting Bar. Follow up to #234.

Steps to Test or Reproduce

Use a prefix like https://Test.zoom.us/j/ in the meeting location field. The prior regex would not pick this up.

My company has a cased subdomain whose meeting location were not being picked up by Meeting Bar.
@leits leits merged commit 1cbe619 into leits:master May 3, 2021
@JamesMcMahon JamesMcMahon deleted the patch-1 branch May 3, 2021 20:00
@JamesMcMahon
Copy link
Contributor Author

Is there a desire to make all the meeting urls case insensitive? If so, I can revise the approach to be more all encompassing.

(If this is the wrong place to discuss I can also open a follow up issue.)

@leits
Copy link
Owner

leits commented May 3, 2021

Thanks, @JamesMcMahon.

So far, this is the first time the need has arisen.
Most services do not have a self-hosted version and those that do have usually use lowercase domains.

If there is at least one more case, then we can think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants