Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Gather meeting service #670

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

ttakuya50
Copy link
Contributor

Status

READY

Description

The Gather icon did not appear, although it is officially listed as "Gather compatible." We checked the code and found that there was an additional part that needed to be implemented.

Before
スクリーンショット 2023-11-20 5 35 43

After
スクリーンショット 2023-11-20 5 17 50

Checklist

Steps to Test or Reproduce

If you paste the Gather URL into your schedule and check the MeetingBar, you will see the Gather icon appear.

@ttakuya50
Copy link
Contributor Author

Test failed due to unrelated error: Unable to resolve action devbotsxyz/xcode-select, repository not found

@leits
Copy link
Owner

leits commented Nov 22, 2023

Thanks!

@leits leits merged commit 0782abf into leits:master Nov 22, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants