chopper base.dart send() authenticate sending wrong request

[ssierputowski11]

See 5.1.0 to see the authenticate is using the req object.

See 5.2.0 and authenticate is using request object

See latest and similar result as above.

Is this by design? I saw another issue #308 that brings this up as well. I used that fix locally and it solved it as well.

Could this be addressed if it is a bug?

[techouse]

Is this by design?

This used to be a bug #388 that I fixed in #390.

Could this be addressed if it is a bug?

I'm not sure. Can you explain the issue you're actually facing?

[ssierputowski11]

I'm not sure. Can you explain the issue you're actually facing?

Yes the authenticate call is not passing in the intercepted request.

Original: final Request? updatedRequest = await authenticator!.authenticate( request, res, request, );

We could potentially have something wrong but that request object is passed through twice. Changing this value to final Request? updatedRequest = await authenticator!.authenticate( req, res, request, ); fixes the issue that I am having. The issue being the request object does not have Header information but the req does contain the Header information

[techouse]

The issue being the request object does not have Header information but the req does contain the Header information

I see. Thank's for the input!

Can you please try out the changes I have made in the PR #497. Add this to your pubspec.yaml to install chopper from the PR:

dependency_overrides:
  chopper:
    git:
      url: https://github.com/techouse/chopper.git
      ref: fix/492-authenticator-req-request
      path: chopper

In this PR I've re-implemented the fix of #390 by checking if the request.body is already a JSON encoded String before attempting to json.encode it.

[ssierputowski11]

Looks to be reauthenticating properly and the Headers are being passed back to our override functions. Thanks! I'll keep an eye out on the updates and get this implemented when it gets updated

[techouse]

when it gets updated

@ssierputowski11 v7.0.6 just landed on pub.dev :)