Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix ChopperClient.send() sending wrong request when using an Authenticator #497

Merged
merged 3 commits into from Sep 2, 2023
Merged

🐛 fix ChopperClient.send() sending wrong request when using an Authenticator #497

merged 3 commits into from Sep 2, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Sep 1, 2023

Fixes #492

Also fixes #388 and properly implements #390 by checking if the request.body is already a JSON before encoding it to JSON thereby preventing duplicate JSON encoding when using the authenticator.

@techouse techouse added the bug Something isn't working label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited

Codecov Report

Merging #497 (c4ef2a6) into develop (e706150) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #497      +/-   ##
===========================================
+ Coverage    93.83%   93.87%   +0.04%     
===========================================
  Files            9        9              
  Lines          454      457       +3     
===========================================
+ Hits           426      429       +3     
  Misses          28       28
Files Changed Coverage Δ
chopper/lib/src/base.dart 94.65% <100.00%> (ø)
chopper/lib/src/interceptor.dart 75.38% <100.00%> (+1.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced Sep 1, 2023
Closed
Merged
@techouse techouse merged commit a0f106d into lejard-h:develop Sep 2, 2023
6 checks passed
@techouse techouse deleted the fix/492-authenticator-req-request branch September 2, 2023 07:12
@techouse techouse changed the title 🐛 fix chopper base.dart send() authenticate sending wrong request 🐛 fix ChopperClient.send() sending wrong request when using an Authenticator Sep 2, 2023
techouse added a commit that referenced this pull request Sep 2, 2023
@techouse @martinale14
🔖 release v7.0.6 (#496)
7833e70 
# chopper

## 7.0.6

- #493
- #497
- #495

# chopper_built_value

## 2.0.1

- #495

# chopper_generator

## 7.0.3

- #493
- #495

---------

Co-authored-by: Klemen Tusar <techouse@gmail.com>
Co-authored-by: Martin Alejandro Escobar Espinel <56127727+martinale14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chopper base.dart send() authenticate sending wrong request Authenticator corrupts request body
2 participants
@techouse @JEuler