Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas+mmyster/feature/functional tests #1079

Merged
merged 9 commits into from
Oct 24, 2022
Merged

ladislas+mmyster/feature/functional tests #1079

merged 9 commits into from
Oct 24, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Oct 21, 2022 •
edited
Loading

replacement of #1020

@ladislas ladislas force-pushed the ladislas+mmyster/feature/functional-tests branch from 6b881d1 to 8b2039b Compare October 21, 2022 14:37
@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169636 (64%) 92508 (35%) 30920 (5%)
os 410936 (26%) 1153736 (73%) 79608 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 410936 (19%) ø 79608 (15%) ø
bootloader ✔️ ✅ ✅ 169636 (8%) ø 30920 (5%) ø
functional_ut_boost_ut ✨ - - 355592 (16%) - 17992 (3%) -
functional_ut_io_expander ✨ - - 331864 (15%) - 17968 (3%) -
functional_ut_qdac ✨ - - 333016 (15%) - 17968 (3%) -
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189752 (9%) ø 48120 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228768 (10%) ø 28200 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_boost_ut ⚰️ - - - - - -
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192520 (9%) ø 50944 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174616 (8%) ø 47888 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162236 (7%) ø 46616 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78564 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 80920 (3%) ø 11520 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114244 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126236 (6%) ø 15304 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 82032 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
functional_ut_boost_ut (click to expand) 


Flash used: 355592 (16%) / total: 2097152
SRAM used: 17992 (3%) / total: 524288
functional_ut_io_expander (click to expand) 


Flash used: 331864 (15%) / total: 2097152
SRAM used: 17968 (3%) / total: 524288
functional_ut_qdac (click to expand) 


Flash used: 333016 (15%) / total: 2097152
SRAM used: 17968 (3%) / total: 524288

@github-actions
Copy link

github-actions bot commented Oct 21, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182012 (69%) 80132 (30%) 37456 (7%)
os 451908 (28%) 1112764 (71%) 86664 (16%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 451908 (21%) ø 86664 (16%) ø
bootloader ✔️ ✅ ✅ 182012 (8%) ø 37456 (7%) ø
functional_ut_boost_ut ✨ - - 367784 (17%) - 24664 (4%) -
functional_ut_io_expander ✨ - - 343768 (16%) - 24632 (4%) -
functional_ut_qdac ✨ - - 344920 (16%) - 24632 (4%) -
spike_lk_audio ✔️ ✅ ✅ 135068 (6%) ø 20984 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198252 (9%) ø 54536 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 236652 (11%) ø 34856 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92236 (4%) ø 18064 (3%) ø
spike_lk_boost_ut ⚰️ - - - - - -
spike_lk_cg_animations ✔️ ✅ ✅ 152264 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 202716 (9%) ø 57872 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138868 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 153984 (7%) ø 21336 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331180 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 173976 (8%) ø 47976 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 171852 (8%) ø 53288 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 91508 (4%) ø 18616 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84700 (4%) ø 18024 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87056 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136188 (6%) ø 20896 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 21912 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87940 (4%) ø 19960 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list
functional_ut_boost_ut (click to expand) 


Flash used: 367784 (17%) / total: 2097152
SRAM used: 24664 (4%) / total: 524288
functional_ut_io_expander (click to expand) 


Flash used: 343768 (16%) / total: 2097152
SRAM used: 24632 (4%) / total: 524288
functional_ut_qdac (click to expand) 


Flash used: 344920 (16%) / total: 2097152
SRAM used: 24632 (4%) / total: 524288

@codecov
Copy link

codecov bot commented Oct 21, 2022 •
edited
Loading

Codecov Report

Merging #1079 (a2a3957) into develop (0bad39d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1079   +/-   ##
========================================
  Coverage    96.05%   96.05%           
========================================
  Files          133      133           
  Lines         3191     3191           
========================================
  Hits          3065     3065           
  Misses         126      126

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannLocatelli
Copy link
Member

I made a review on original PR: #1020 (review) + a PR for CMakeLists simplification #1080

@ladislas ladislas force-pushed the ladislas+mmyster/feature/functional-tests branch 2 times, most recently from b0d1e6b to eea278c Compare October 24, 2022 14:44
@ladislas ladislas requested a review from MMyster October 24, 2022 15:40
@ladislas ladislas self-assigned this Oct 24, 2022
@ladislas ladislas added the 01 - type: task Something to do label Oct 24, 2022
@ladislas ladislas added this to the Future Release milestone Oct 24, 2022
@ladislas ladislas force-pushed the ladislas+mmyster/feature/functional-tests branch from 5183147 to a2a3957 Compare October 24, 2022 15:45
YannLocatelli
YannLocatelli approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified on the robot

A little optional suggestion about CMakeLists of tests' content readability

tests/functional/tests/io_expander/CMakeLists.txt Outdated Show resolved Hide resolved
@YannLocatelli YannLocatelli mentioned this pull request Oct 24, 2022
Closed
ladislas and others added 9 commits October 24, 2022 18:44
@ladislas
🔧 (vscode): CMake - allow optional argument indentation
dd2c8c0
@ladislas
🏗️ (tests): Functional tests scaffolding
bfa6e1c
@ladislas
♻️ (functional): utils - refactor delta w/ lambda
c7ebbbd
@ladislas
🔨 (cmake): Add add_main_to_functional_test cmake function
f19d86d 
- avoid the need for each test to add the test_main.cpp source file
- creates a `TARGET` compile definition used to output the target name
  when running tests
@ladislas
✅ (tests): Functional - add boost::ut test example
be7ebdb
@ladislas
✅ (tests): Functional - add qdac tests
ec1ddd0
@MMyster @ladislas
✅ (tests): Functional - add io expander tests
7a485b0
@MMyster @ladislas
🔨 (tests): Add script to run functional tests
d782a91
@ladislas
♻️ (cmake): Add register_functional_test
799dc5d 
The function takes care of all the boiler plate code needed to register
a new functional test.

This allows developer to add them faster and more easily.
@ladislas ladislas force-pushed the ladislas+mmyster/feature/functional-tests branch from a2a3957 to 799dc5d Compare October 24, 2022 16:47
@ladislas ladislas merged commit 60cbe65 into develop Oct 24, 2022
@ladislas ladislas deleted the ladislas+mmyster/feature/functional-tests branch October 24, 2022 16:48
@ladislas ladislas mentioned this pull request Oct 24, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

@MMyster MMyster Awaiting requested review from MMyster

Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ladislas @YannLocatelli @MMyster