mmyster/feature/functional tests #1020

MMyster · 2022-09-13T12:02:24Z

✅ (functional): add some test templates

codecov · 2022-09-13T12:06:13Z

Codecov Report

Merging #1020 (44b1fa4) into develop (0916527) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1020   +/-   ##
========================================
  Coverage    96.00%   96.00%           
========================================
  Files          133      133           
  Lines         3178     3178           
========================================
  Hits          3051     3051           
  Misses         127      127

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-09-13T12:13:58Z

File comparision analysis report

🔖 Info

base: develop / 0916527 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/functional-tests / 44b1fa4 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	182012 (69%)	80132 (30%)	37456 (7%)
os	446020 (28%)	1118652 (71%)	86280 (16%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	446020 (21%)	ø	86280 (16%)	ø
bootloader	✔️	✅	✅	182012 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	135068 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	198252 (9%)	ø	54536 (10%)	ø
spike_lk_ble	✔️	✅	✅	236652 (11%)	ø	34856 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_boost_ut	✔️	✅	✅	367784 (17%)	ø	24672 (4%)	ø
spike_lk_cg_animations	✔️	✅	✅	152264 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	202716 (9%)	ø	57872 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	138868 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	153984 (7%)	ø	21336 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331180 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	173976 (8%)	ø	47976 (9%)	ø
spike_lk_lcd	✔️	✅	✅	171852 (8%)	ø	53288 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✔️	✅	✅	91508 (4%)	ø	18616 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84700 (4%)	ø	18024 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	136188 (6%)	ø	20896 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	148044 (7%)	ø	21912 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19960 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø
suite_io_expander	✨	-	-	343824 (16%)	-	24640 (4%)	-
suite_qdac	✨	-	-	344976 (16%)	-	24640 (4%)	-

🗺️ Map files diff output

Click to show diff list

suite_io_expander (click to expand)

Flash used: 343824&nbsp;(16%) / total: 2097152
SRAM used: 24640&nbsp;(4%) / total: 524288

suite_qdac (click to expand)

Flash used: 344976&nbsp;(16%) / total: 2097152
SRAM used: 24640&nbsp;(4%) / total: 524288

github-actions · 2022-09-13T12:14:36Z

File comparision analysis report

🔖 Info

base: develop / 0916527 + mbed-os-6.15.1+fixes + -std=c++20
head: mmyster/feature/functional-tests / 44b1fa4 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	169636 (64%)	92508 (35%)	30920 (5%)
os	407848 (26%)	1156824 (73%)	79224 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	407848 (19%)	ø	79224 (15%)	ø
bootloader	✔️	✅	✅	169636 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	125076 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	189752 (9%)	ø	48120 (9%)	ø
spike_lk_ble	✔️	✅	✅	228768 (10%)	ø	28200 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_boost_ut	✔️	✅	✅	355600 (16%)	ø	18000 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	192520 (9%)	ø	50944 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	126956 (6%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	139016 (6%)	ø	14416 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	327112 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	174616 (8%)	ø	47888 (9%)	ø
spike_lk_lcd	✔️	✅	✅	162236 (7%)	ø	46616 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78564 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80920 (3%)	ø	11520 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	114244 (5%)	ø	14056 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	126236 (6%)	ø	15304 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	82032 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø
suite_io_expander	✨	-	-	331928 (15%)	-	17976 (3%)	-
suite_qdac	✨	-	-	333080 (15%)	-	17976 (3%)	-

🗺️ Map files diff output

Click to show diff list

suite_io_expander (click to expand)

Flash used: 331928&nbsp;(15%) / total: 2097152
SRAM used: 17976&nbsp;(3%) / total: 524288

suite_qdac (click to expand)

Flash used: 333080&nbsp;(15%) / total: 2097152
SRAM used: 17976&nbsp;(3%) / total: 524288

lgtm-com · 2022-09-19T07:38:37Z

This pull request introduces 3 alerts when merging cd3cf75 into fb30049 - view on LGTM.com

new alerts:

2 for Unused import
1 for Unused local variable

lgtm-com · 2022-09-19T07:42:50Z

This pull request introduces 3 alerts when merging cd3cf75 into fef74dd - view on LGTM.com

new alerts:

2 for Unused import
1 for Unused local variable

ladislas

very interesting PR! 👍 I've made a lot of comments for small typos or naming and a few suggestions to improve the structure

tests/functional/CMakeLists.txt

tests/functional/template_success/CMakeLists.txt

tests/functional/template_failure/CMakeLists.txt

tests/functional/_no_test/CMakeLists.txt

tools/run_functional_tests.py

lgtm-com · 2022-09-23T08:20:52Z

This pull request introduces 3 alerts when merging c932135 into d6ac5eb - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure
1 for Unused local variable
1 for Unreachable code

lgtm-com · 2022-09-23T09:42:56Z

This pull request introduces 3 alerts when merging 6b3764f into 85fa678 - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure
1 for Unused local variable
1 for Unreachable code

lgtm-com · 2022-09-23T10:36:06Z

This pull request introduces 3 alerts when merging b7d8e3c into 0fef3e2 - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure
1 for Unused local variable
1 for Unreachable code

lgtm-com · 2022-10-04T07:48:41Z

This pull request introduces 1 alert when merging 1599613 into 0ca2806 - view on LGTM.com

new alerts:

1 for Use of the return value of a procedure

sonarcloud · 2022-10-14T15:12:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

tools/run_functional_tests.py

tests/functional/sources/IOExpander/suite_io_expander.cpp

YannLocatelli · 2022-10-21T14:01:43Z

tests/functional/sources/QDAC/suite_qdac.cpp

+		channel = 0x00;
+		dac.write(channel, data);
+		auto ret = dac.read(channel);
+		expect(data == ret) << "Failed to read Channel A";


Just for precision, the string "Failed to read Channel A" is only displayed if expect failed? It's the message error?

Yes, it is. But as I said, it is currently not functional. I was planning to take a look at it later or delete it by default.

tests/functional/CMakeLists.txt

YannLocatelli · 2022-10-21T15:41:39Z

tools/run_functional_tests.py

+        CMD_FLASH = "openocd -f interface/stlink.cfg -c 'transport select hla_swd' -f target/stm32f7x.cfg -c 'program " + \
+            self.path+" 0x08000000' -c exit"


This script has a lot of operation and it's hard to review it in one review.

Just a comment for now, some information and command as CMD_FLASH should have same source.

ladislas · 2022-10-24T16:48:20Z

closed by #1079

MMyster force-pushed the mmyster/feature/functional-tests branch 3 times, most recently from 7ef5e3d to cd3cf75 Compare September 19, 2022 07:33

MMyster changed the base branch from develop to mmyster/feature/lk-unit-testing-framework-boost-ut September 19, 2022 07:34

MMyster force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from fef74dd to d6ac5eb Compare September 19, 2022 07:36

MMyster self-assigned this Sep 19, 2022

MMyster requested review from ladislas and YannLocatelli September 19, 2022 07:36

MMyster added the 01 - type: task Something to do label Sep 19, 2022

MMyster modified the milestones: Next Release, Future releases Sep 19, 2022

ladislas requested changes Sep 19, 2022

View reviewed changes

ladislas modified the milestones: Next Release, Future releases Sep 20, 2022

MMyster force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from d6ac5eb to 85fa678 Compare September 23, 2022 09:31

MMyster force-pushed the mmyster/feature/functional-tests branch from c932135 to 6b3764f Compare September 23, 2022 09:34

MMyster force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from 85fa678 to 0fef3e2 Compare September 23, 2022 10:15

MMyster force-pushed the mmyster/feature/functional-tests branch from 6b3764f to b7d8e3c Compare September 23, 2022 10:31

ladislas force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from 0fef3e2 to c8b9b83 Compare September 26, 2022 12:20

ladislas force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch 4 times, most recently from 6b4d646 to 0ca2806 Compare September 30, 2022 07:02

MMyster force-pushed the mmyster/feature/functional-tests branch from b7d8e3c to 1599613 Compare October 4, 2022 07:39

MMyster force-pushed the mmyster/feature/functional-tests branch 2 times, most recently from 45cffaf to 0227940 Compare October 6, 2022 09:06

MMyster force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from 0ca2806 to 542354b Compare October 6, 2022 09:23

MMyster requested a review from ladislas October 6, 2022 13:06

ladislas force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch from 542354b to fe75819 Compare October 10, 2022 15:42

MMyster force-pushed the mmyster/feature/functional-tests branch from 931ea58 to e7be829 Compare October 11, 2022 13:39

ladislas force-pushed the mmyster/feature/lk-unit-testing-framework-boost-ut branch 2 times, most recently from 54810ed to 79830ae Compare October 11, 2022 18:29

Base automatically changed from mmyster/feature/lk-unit-testing-framework-boost-ut to develop October 11, 2022 18:29

MMyster force-pushed the mmyster/feature/functional-tests branch 3 times, most recently from 934eba6 to 3d4c1cf Compare October 14, 2022 14:39

MMyster added 3 commits October 14, 2022 17:03

✅ (functional): Add test functional QDAC

3cb49fa

✅ (functional): Add test functional IOExpander

f7a9488

:chart_with_upward_trend: (tools): run functional tests

44b1fa4

MMyster force-pushed the mmyster/feature/functional-tests branch from 3d4c1cf to 44b1fa4 Compare October 14, 2022 15:04

MMyster mentioned this pull request Oct 14, 2022

mmyster/feature/test functional file manager #1065

Closed

1 task

ladislas mentioned this pull request Oct 21, 2022

ladislas+mmyster/feature/functional tests #1079

Merged

YannLocatelli reviewed Oct 21, 2022

View reviewed changes

ladislas closed this Oct 24, 2022

ladislas deleted the mmyster/feature/functional-tests branch October 24, 2022 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mmyster/feature/functional tests #1020

mmyster/feature/functional tests #1020

MMyster commented Sep 13, 2022 •

edited

Loading

codecov bot commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading

lgtm-com bot commented Sep 19, 2022

lgtm-com bot commented Sep 19, 2022

ladislas left a comment

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Oct 4, 2022

sonarcloud bot commented Oct 14, 2022

YannLocatelli Oct 21, 2022

MMyster Oct 24, 2022

YannLocatelli Oct 21, 2022 •

edited

Loading

ladislas commented Oct 24, 2022

		CMD_FLASH = "openocd -f interface/stlink.cfg -c 'transport select hla_swd' -f target/stm32f7x.cfg -c 'program " + \
		self.path+" 0x08000000' -c exit"

mmyster/feature/functional tests #1020

mmyster/feature/functional tests #1020

Conversation

MMyster commented Sep 13, 2022 • edited Loading

codecov bot commented Sep 13, 2022 • edited Loading

Codecov Report

github-actions bot commented Sep 13, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Sep 13, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

lgtm-com bot commented Sep 19, 2022

lgtm-com bot commented Sep 19, 2022

ladislas left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Sep 23, 2022

lgtm-com bot commented Oct 4, 2022

sonarcloud bot commented Oct 14, 2022

YannLocatelli Oct 21, 2022

Choose a reason for hiding this comment

MMyster Oct 24, 2022

Choose a reason for hiding this comment

YannLocatelli Oct 21, 2022 • edited Loading

Choose a reason for hiding this comment

ladislas commented Oct 24, 2022

MMyster commented Sep 13, 2022 •

edited

Loading

codecov bot commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022 •

edited

Loading

YannLocatelli Oct 21, 2022 •

edited

Loading