hugo/feature/Add ReinforcerKit #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Aug 25, 2022
HPezz
commented
- ✨ (libs): Add ReinforcerKit
- ✅ (tests): Add ReinforcerKit_test.cpp
- 🔥 (behavior): Remove Reinforcers from BehaviorKit
- 🎨 (commandkit): Update ReinforcerCommand
- 🎨 (os): Update OS with ReinforcerKit
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #980 +/- ##
===========================================
- Coverage 96.01% 95.93% -0.09%
===========================================
Files 129 129
Lines 2987 3001 +14
===========================================
+ Hits 2868 2879 +11
- Misses 119 122 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
from
76eedc3
to
822669e
Compare
ladislas
requested changes
Sep 1, 2022
HPezz
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
2 times, most recently
from
3bb82ce
to
bb06e78
Compare
YannLocatelli
approved these changes
Sep 2, 2022
Comment on lines
17
to
19
| void ReinforcerKit::run(const Reinforcer &reinforcer) | ||
| { | ||
| switch (reinforcer) { |
There was a problem hiding this comment.
Suggestion un peu barbare, avoir un run qui prend en paramètre un Reinforcer en pointeur et s'il est nul de pouvoir lancer le renforçateur par défaut.
Suggested change
| void ReinforcerKit::run(const Reinforcer &reinforcer) | |
| { | |
| switch (reinforcer) { | |
| void ReinforcerKit::run(const Reinforcer *reinforcer = nullptr) | |
| { | |
| auto selected_reinforcer = *reinforcer == nullptr ? _default_reinforcer : *reinforcer | |
| switch (selected_reinforcer) { |
Ca permettrait de l'extérieur de simplifier encore plus les choses en ayant uniquement que setDefaultReinforcer
et run en fonctions d'appels de ReinforcerKit plutôt que de se dire "si je ne sais pas quel renforçateur appeler, il faut appeler une autre fonction"
HPezz
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
from
bb06e78
to
3c3f3fa
Compare
HPezz
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
from
7f05e35
to
bbe826d
Compare
ladislas
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
from
66ddd4a
to
6ac5c30
Compare
ladislas
force-pushed
the
hugo/feature/Add-ReinforcerKit
branch
from
6ac5c30
to
0afcd0b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.