Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add deploy with github action #302

Merged
merged 2 commits into from
Sep 18, 2021
Merged

PR: Add deploy with github action #302

merged 2 commits into from
Sep 18, 2021

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented May 7, 2020

Repo: https://github.com/lektor/_deployed-lektor-website
Web: https://lektor.github.io/_deployed-lektor-website/

I added a temporal token to test the deploy, but the idea would be to have a bot user on github to do this. We would need the credentials of that bot (if it exists) and create a token with the required permits.

We can also update the docs to include github actions and point to this repo as example.

@goanpeca goanpeca force-pushed the enh/gh-action-deploy branch 2 times, most recently from a6eba2e to ebbda1f Compare May 7, 2020 02:29
@goanpeca goanpeca requested review from nixjdm, runfalk and xlotlu May 7, 2020 02:33
@goanpeca goanpeca self-assigned this May 7, 2020
@@ -1,14 +1,26 @@
[project]
name = Lektor
url = https://www.getlektor.com/
url_style = absolute
url_style = relative
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to get GHPages working. But once we move we can go back to absolute.

@goanpeca
Copy link
Member Author

goanpeca commented May 7, 2020

I think the changes I made to the TRAVIS file will fix the issue in the meantime.

Copy link
Contributor

@dairiki dairiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates for the deploy action.

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@yagebu yagebu merged commit 98ed6a5 into master Sep 18, 2021
@yagebu yagebu deleted the enh/gh-action-deploy branch September 18, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants