Fix for #1031: "multiple not valid with is_flag" from click 8.1.3 #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for the `--name`, `--project-file`, `--tree`, and `--output-path` options to the `lektor project-info` subcommand.
The latest release of click raises `TypeError` for Options that are declared with both `multiple` and `is_flag` set. The exception message suggests using `count` instead, but that does not do what we want. This commit rejiggers things to avoid the use of `multiple` on `is_flag` options. Reference: lektor#1031.
dairiki
force-pushed
the
bug.1031-click-multiple-not-valid-with-is_flag
branch
from
99b94a7
to
6238e13
Compare
dairiki
added a commit
that referenced
this pull request
May 2, 2022
webknjaz
added a commit
to Omikron-Voiceover/omikron.com.ua
that referenced
this pull request
May 2, 2022
dairiki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of click raises
TypeErrorfor Options that aredeclared with both
multipleandis_flagset. The exception messagesuggests using
countinstead, but that does not do what we want.This commit rejiggers things to avoid the use of
multipleonis_flagoptions.Issue(s) Resolved
Fixes #1031
Related Issues / Links
Description of Changes