Fix extra_flag crash #1042
Merged
Fix extra_flag crash #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parametrizes the app fixture to supply apps with and without extra-flags. Not the smallest possible testcase but it does the trick for now
|
@bockstaller Thank you for the diagnosis and the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Fixes #1041
Description of Changes
LektorContext.builder(...)is now using a keyword argument for extra_flags to match the signature ofBuilder.__init__(...)and prevent passing them as thebuildstate_path.I've added a fixture to generate apps with and without flags. This adds more testcases than necessary but is the easiest solution regarding my knowledge of the codebase.