Be more careful about handling TypeError from plugin hook method calls #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
changed the title
dairiki
added a commit
that referenced
this pull request
Nov 5, 2022
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PluginController.emit, under certain circumstances, will silently ignoreTypeErrors raised by plugin hook methods.This fixes that.
In addition, each call to
emitwill now call each hook method at most once. Previously, under some circumstances, a hook method could be called twice during a single call toemit— that could possibly have unintended and confusing consequences for hooks that mutate plugin state.Issue(s) Resolved
Fixes #1085
Description of Changes