Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pillow rather than Imagemagick for thumbnail generation #1104

Merged
merged 18 commits into from
Apr 22, 2023
Merged

Use Pillow rather than Imagemagick for thumbnail generation #1104

merged 18 commits into from
Apr 22, 2023

Commits on Apr 22, 2023

  1. feat(imagetools): use Pillow (instead of imagemagick) for thumbnailing

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    01057f4 View commit details
    Browse the repository at this point in the history

  2. feat(imagetools): clean up remnants of imagemagick config

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ede0c49 View commit details
    Browse the repository at this point in the history

  3. test(imagetools): enable mypy checks

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    5822b33 View commit details
    Browse the repository at this point in the history

  4. style: delete "yay shitty library" null strptime 

    Nobody knows why it is here
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    f009e05 View commit details
    Browse the repository at this point in the history

  5. refactor(imagetools): convert Thumbnail to a dataclass

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ef8bb12 View commit details
    Browse the repository at this point in the history

  6. test(imagetools): add color-space handling test page to test demo pro… 

    …ject
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    19f3710 View commit details
    Browse the repository at this point in the history

  7. fix: get_image_info(): return format=None for short file 

    Previous `format=`"unknown"` was being returned for short files, while
`None` was being returned for all other unrecognized image files.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    e22a3bd View commit details
    Browse the repository at this point in the history

  8. test(imagetools): unit tests for new code in imagetools

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    604d8c7 View commit details
    Browse the repository at this point in the history

  9. refactor(imagetools): omit sRGB color profile from thumbnails 

    After some experimentation, it turns out that the old imagemagick code
just discarded any embedded color profile from the source image.

After this commit, we attempt to transform the source image from any
embedded color profile to sRGB, but still omit the sRGB color profile
from the resulting thumbnail.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    bc4f86d View commit details
    Browse the repository at this point in the history

  10. refactor(imagetools): make Pillow a required dependency

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    fb52152 View commit details
    Browse the repository at this point in the history

  11. refactor(tests): remove test_images.py 

    Remove test_images.py after ensuring that all of its tests are
replicated in test_imagetools.py.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    1a74800 View commit details
    Browse the repository at this point in the history

  12. fix(imagetools): _combine_make - return model (not make) 

    If the model contains the make, we want the model as the combined
value.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    dd9cc55 View commit details
    Browse the repository at this point in the history

  13. test: Test with older versions of Pillow - 6.0.x and 7.0.x

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    408d8a2 View commit details
    Browse the repository at this point in the history

  14. fix: fixes for Pillow versions 6.x and 7.x

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    46c8a03 View commit details
    Browse the repository at this point in the history

  15. refactor(imagetools): encapsulate thumbnail parameters in dataclass

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ec357bc View commit details
    Browse the repository at this point in the history

  16. test(imagetools): test that Pillow does not implicitly save metadata

    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    432ec7e View commit details
    Browse the repository at this point in the history

  17. feat!: convert warning to error when thumbnail dim missing 

    Since Lektor==3.2.dev0 make_image_thumbnail has been issuing a warning
and falling back to FIT mode when called without both a thumbnail
width and height when the mode other than FIT.

Now we raise ValueError in that case.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    04ff742 View commit details
    Browse the repository at this point in the history

  18. Revert "ci: pin coverage<7.0.2 on macOS (lektor#1132)" 

    This seems possibly no longer necessary to prevent the macOS CI run
from hanging. (See lektor#1132.)

This reverts commit 7960115.
    @dairiki
    dairiki committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    ab7638c View commit details
    Browse the repository at this point in the history