Update/fix resolution of relative output path #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
force-pushed
the
fix.1103-output-path
branch
2 times, most recently
from
a5b5235
to
7e9e9cb
Compare
Previous was interpreting relative to the *project tree* (which is usually, but not always, the same as the location of the project file.)
dairiki
force-pushed
the
fix.1103-output-path
branch
from
d29efd0
to
cce697a
Compare
1 task
dairiki
added a commit
to dairiki/lektor-website
that referenced
this pull request
Mar 11, 2023
Note that --output-path is (now) interpreted relative to the current working directory.
dairiki
force-pushed
the
fix.1103-output-path
branch
from
481e864
to
96ca173
Compare
1 task
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
* fix(cli): interpret --output-path relative to the current working directory * fix(project): interpret `output_path` relative to project file Previous was interpreting relative to the *project tree* (which is usually, but not always, the same as the location of the project file.) * fix: click.Path(resolve_path=True) doesn't always work on Windows See pallets/click#2466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--output-pathis interpreted relative to the current working directory.Project.get_output_pathto resolve a relativeoutput_pathconfigured in the project file relative to the location of the project file (as the docs claim should happen).Issue(s) Resolved
Fixes #1103
Related Issues / Links
Doc updates in lektor/lektor-website#367
Description of Changes