Fix local plugin installation #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dairiki
force-pushed
the
fix.1127-pip-breakage
branch
2 times, most recently
from
5760dc4
to
e7db062
Compare
The most recent version of pip (23.1) removes support for the `--install-option` parameter to `pip install`. This breaks our `install_local_package` function, which uses `--install-option` because `pip install --target` didn't used to work with `pip install --editable`. As it turns out, recent versions of pip support the use of `--target` with `--editable`. So here we make use of that. Note that this also relieves us of the need to parse our local plugin requirements ourselves (thus, hopefully, fixing lektor#865.)
dairiki
force-pushed
the
fix.1127-pip-breakage
branch
from
e7db062
to
dca38f0
Compare
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent version of pip (23.1) removes support for the
--install-optionparameter topip install. This breaks ourinstall_local_packagefunction, which uses--install-optionbecausepip install --targetdidn't used to work withpip install --editable.As it turns out, recent versions of pip support the use of
--targetwith--editable. So here we make use of that.Note that this also relieves us of the need to parse our local plugin requirements ourselves (thus, hopefully, fixing e.g. #865.)
Issue(s) Resolved
Fixes #1127
Related Issues / Links
This is a (more minimal) alternative to PR #1128.
Description of Changes
We did not have a test that detects the breakage caused by the recent
pipupdate. We now have one.