Markdown backward compatibility improvements #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
force-pushed
the
fix.markdown-bc
branch
3 times, most recently
from
aaffb3e
to
650d122
Compare
The hope is that markdown-customizing plugins that were written for Lektor<3.4 will continue to work (so long as mistune is pinned to 0.x.)
dairiki
force-pushed
the
fix.markdown-bc
branch
from
650d122
to
52c80c0
Compare
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
* fix: make lektor.markdown.ImprovedRenderer etc available The hope is that markdown-customizing plugins that were written for Lektor<3.4 will continue to work (so long as mistune is pinned to 0.x.) * test(markdown): add a test with a legacy (Lektor<3.4) style plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
lektor.markdown.ImprovedRenderer(along withescapeandMarkdownConfig) available once again.These were removed in #992 in the changes made to support running with either mistune 0.x or mistune 2.x.
With this PR, those items are back (though their use will elicit an DeprecationWarning).
The hope is that markdown-customizing plugins that were written for Lektor<3.4 will continue to work (so long as mistune is pinned to 0.x — getting old plugins to work without modification under mistune 2.x is a whole different kettle of fish, since mistune fairly completely change the call signatures of the important renderer methods between versions.)
Issue(s) Resolved
Related Issues / Links
Description of Changes