Fix: reduce number of deprecation warnings #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
force-pushed
the
fix.too-many-deprecation-warnings
branch
from
981f05a
to
1bc82bc
Compare
dairiki
force-pushed
the
fix.too-many-deprecation-warnings
branch
from
1bc82bc
to
415a7a9
Compare
There is (arguably) a bug in Python's warnings module, such that every use of warnings.catch_warnings erases all memory of which warnings have been displayed. This breaks the "default" setting of the warnings filter which is supposed to ensure that each warning is only displayed once per (module, line). So here, we disuse catch_warnings. See https://bugs.python.org/issue29672
dairiki
force-pushed
the
fix.too-many-deprecation-warnings
branch
from
415a7a9
to
5d9c24c
Compare
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
There is (arguably) a bug in Python's warnings module, such that every use of warnings.catch_warnings erases all memory of which warnings have been displayed. This breaks the "default" setting of the warnings filter which is supposed to ensure that each warning is only displayed once per (module, line). So here, we disuse catch_warnings. See https://bugs.python.org/issue29672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@lektor.utils.deprecateddecorator introduced in #1113 uses thewarnings.catch_warningscontext manager to suppress deprecation warnings generated within the body of deprecated functions.As it turns out, there is (arguably) a bug in Python's warnings module, such that every use of
warnings.catch_warningsessentially erases all record of which warnings have been displayed.This breaks the "default" setting of the warnings filter which is supposed to ensure that each warning is only displayed once per (module, line).
So here, we disuse catch_warnings.
Description of Changes