Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove the --profile option from the build command #1137

Merged
merged 1 commit into from May 24, 2023

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Apr 22, 2023

Running lektor build --profile just runs Builder.build_all under cProfile, then prints the stats.

The profile information is only really interesting to Lektor developers. Lektor can be profiled directly like this:

python -m cProfile -o prof.out -m lektor build
python -m pstats prof.out

@dairiki dairiki added this to the 3.4 milestone Apr 24, 2023
Copy link
Contributor

@yagebu yagebu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Running `lektor build --profile` just runs the build_all under
`cProfile`, then prints the stats.

The profile information is only really interesting to Lektor
developers.  Lektor can be profiled directly like this:

    python -m cProfile -o prof.out -m lektor build
    python -m pstats prof.out
@dairiki dairiki force-pushed the refactor.remove-build-profile-option branch from 478c989 to 0540d95 Compare May 24, 2023 17:17
@dairiki dairiki merged commit 7b6c381 into lektor:master May 24, 2023
15 checks passed
@dairiki dairiki deleted the refactor.remove-build-profile-option branch May 24, 2023 17:35
dairiki added a commit to dairiki/lektor that referenced this pull request Sep 11, 2023
…#1137)

Running `lektor build --profile` just runs the build_all under
`cProfile`, then prints the stats.

The profile information is only really interesting to Lektor
developers.  Lektor can be profiled directly like this:

    python -m cProfile -o prof.out -m lektor build
    python -m pstats prof.out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants