Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symlinks when creating virtual environments — fixes #1159 #1161

Merged
merged 1 commit into from Aug 29, 2023

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Aug 29, 2023

This changes things to use symlinks when constructing Lektor's private virtual environment.

By default, python -m venv uses symlinks, except when running on Windows (where symlinks can be problematic). However when creating a virtual environment programmatically, venv.EnvBuilder defaults to not using symlinks.

Using symlinks is better (everywhere except maybe on Windows) because:

Issue(s) Resolved

Fixes #1159

Related Issues / Links

Description of Changes

  • Added unit test(s) covering the changes (if testable)

@dairiki dairiki merged commit 26f5eac into lektor:master Aug 29, 2023
15 checks passed
dairiki added a commit to dairiki/lektor that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lektor cached venv is broken on macOS with Python installed via Homebrew
1 participant