Update pylint, black &c. versions. Use flake8-bugbear style plugin #1162

dairiki · 2023-08-29T01:03:41Z

In tox.ini:

Update pylint 2.15.8 → 2.17.5 (in tox.ini)

In .pre-commit-config.yaml, update:

black 22.12.0 → 23.7.0 (.pre-commit-config.yaml)
reorder-python-imports 3.9.0 → 3.10.0
flake8 6.0.0 → 6.1.0
add flake8-bugbear plugin to flake8 config

Then make all the resulting suggested style changes (or add ignores)...

- Use dict literals, rather than calling dict() - In get_image_info, raise a more specific exception than Exception - Remove unnecessary else following a raise

yagebu

Thanks :)

dairiki added 4 commits August 28, 2023 17:48

style: follow suggestions surfaced by latest pylint (2.17.5)

5d68bd5

- Use dict literals, rather than calling dict() - In get_image_info, raise a more specific exception than Exception - Remove unnecessary else following a raise

chore: run pre-commit autoupgrade, then pre-commit run -a

4d41f3e

style: run flake8-bugbear in pre-commit

59407dc

style: fix (or ignore) style warnings surfaced by flake8-bugbear

7cb4bd7

yagebu approved these changes Aug 29, 2023

View reviewed changes

yagebu merged commit 795a55c into lektor:master Aug 29, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pylint, black &c. versions. Use flake8-bugbear style plugin #1162

Update pylint, black &c. versions. Use flake8-bugbear style plugin #1162

dairiki commented Aug 29, 2023

yagebu left a comment

Update pylint, black &c. versions. Use flake8-bugbear style plugin #1162

Update pylint, black &c. versions. Use flake8-bugbear style plugin #1162

Conversation

dairiki commented Aug 29, 2023

yagebu left a comment

Choose a reason for hiding this comment