Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tool drawer for edit and live-reload buttons #1164

Merged
merged 4 commits into from
Nov 12, 2023
Merged

feat: tool drawer for edit and live-reload buttons #1164

merged 4 commits into from
Nov 12, 2023

Commits on Nov 8, 2023

  1. feat: tool drawer for edit and live-reload buttons 

    This replaces the *edit pencil* on HTML artifacts served by the admin
server with "tool drawer".

The tool drawer contains an edit button (which takes the place of the
edit pencil), as well as a toggle button that can be used to disable
live-reload (see lektor#1027) for the window.

If the tool drawer is obscuring part of the HTML page that one would
like to look at or click on, the drawer may be dragged vertically
to reposition it.  It may also be (mostly) hidden off screen to
minimize its visual impact.
    @dairiki
    dairiki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e30bf02 View commit details
    Browse the repository at this point in the history

  2. feat(admin gui): use link for "Return to Website" button 

    Using a real link (`<a href="...">`) instead of a button with onclick
handler allows the user to, e.g., open a new window with a
live-preview by middle or right clicking on the button.

Anyway, since the "button" leads to a new URL outside of the admin
app, it's the right thing to do.  E.g. see
https://css-tricks.com/buttons-vs-links/.
    @dairiki
    dairiki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    88317a0 View commit details
    Browse the repository at this point in the history

  3. perf: do not use React's StrictMode in production 

    Strict mode causes everything to be rendered twice. (I noticed this
because GlobalActions was firing off two request for /previewinfo for
every page change.) This is not particularly efficient, and is
probably not appropriate for the production build.
    @dairiki
    dairiki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    727eba4 View commit details
    Browse the repository at this point in the history

  4. revert: remove --no-reload cli option 

    The `--no-reload` option was add in PR lektor#1027 (c38596a).  It disables
the live-reload feature globally.  Since this PR adds the ability to
disable live-reload on a per-window basis, the global option no longer
seems necessary.
    @dairiki
    dairiki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8589078 View commit details
    Browse the repository at this point in the history